feat: remove the experiment flag for the `sandbox` commands and add new partner template IDs by vegeris · Pull Request #512 · slackapi/slack-cli

vegeris · 2026-04-28T19:22:03Z

Changelog

This is effectively the release of the sandbox commands and should be highlighted in the changelog:

slack sandbox create
slack sandbox delete
slack sandbox list

Details:

When creating a sandbox, users provide a name and domain for the sandbox, and a password for their user in the sandbox. Regular sandboxes can optionally use the 'default' or 'empty' templates. Partner developers can create partner sandboxes, which have some additional templates available to them (eg. 'finance' or 'hr' use cases). [The partner templates were added in this PR]

Users can view their sandboxes with the list command and delete sandboxes with the delete command.

Summary

This PR removes the experiment flag currently required to run the sandbox commands

Testing

Instead of:

lack sandbox list --experiment=sandboxes

We can run:

lack sandbox list

Requirements

I've read and understood the Contributing Guidelines and have done my best effort to follow them.
I've read and agree to the Code of Conduct.

codecov · 2026-04-28T19:25:57Z

Codecov Report

❌ Patch coverage is 20.00000% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.22%. Comparing base (e1112eb) to head (5ff1a11).

Files with missing lines	Patch %	Lines
internal/prompts/team_select.go	0.00%	7 Missing ⚠️
cmd/sandbox/sandbox.go	50.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #512      +/-   ##
==========================================
- Coverage   71.27%   71.22%   -0.05%     
==========================================
  Files         222      222              
  Lines       18682    18665      -17     
==========================================
- Hits        13316    13295      -21     
- Misses       4187     4189       +2     
- Partials     1179     1181       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

vegeris · 2026-04-29T14:29:28Z

At line 80 there was a recommendation to use charm for the 'Choose a Slack team where your email address matches...' info message; is charm stable yet, such that we can make that change?

Huh (Charm) is now the default and only prompt library. So, if you're using a prompt then you're now using Charm's Huh :)

yea perhaps we get rid of that comment?

Ah, gotcha :) Updated to use the 'Help' config for the prompt instead of a separate log statement

vegeris · 2026-04-29T14:31:07Z

+	"it-incident-management": 4,
+	"customer-support":       5,
+	"sales":                  6,
+	"marketing":              7,


This PR also adds mappings for the new partner templates

Thanks @vegeris. In the future, it would be better for this to be a separate PR so that it can stand out in the GitHub Release Notes and Changelog.

suggestion: Can you please update the Changelog section of this PR Description so that the documentation team knows to document it on docs.slack.dev.

suggestion: @vegeris Can you please add these to the Long Description so that developers can discover the partner template Ids that are available to use?

I wasn't sure if we would want to highlight it in the Long Description as the grand majority of users would be regular non-partner developers; for the list command for example, we only add the 'sandbox type' label to partner sandboxes to reduce visual noise for regular sandboxes

document it on docs.slack.dev

Speaking of, I'd like to double check the process for getting new commands documented. My current assumption was that we would have a brief announcement in the Changelog through this PR and that once these changes are included in a release, that I would post in #api-docs to get the commands documented on docs.slack.dev?

Also, if there's a strong preference I can apply the changes unrelated to removing the experiment flag first and then come back to this PR

process for getting new commands documented

@vegeris The changelog included in the PR description might be alright to find this with next release! But let's keep watch of the published release! Reference should be generated automatic FWIW.

Perhaps now we can also update the experiments page to note the conclusion?

🔗 https://docs.slack.dev/tools/slack-cli/reference/experiments

👾 ramble: I might also agree with separate PRs for future changes to make review more "obvious" for me with a single focused mind but I understand this now 🌚

I wasn't sure if we would want to highlight it in the Long Description as the grand majority of users would be regular non-partner developers

I feel we under utilitize the Long Description at the moment. We should feel comfortable documenting commands at length in the Long Description. After all, it's only shown when a developer wants to learn about that command, specifically. It's also generated into a webpage on docs.slack.dev.

All of that is to say, feel free to go full essay in a Long Description.

My current assumption was that we would have a brief announcement in the Changelog through this PR and that once these changes are included in a release, that I would post in #api-docs to get the commands documented on docs.slack.dev?

Yep, this is a good approach. Typically, the docs team is good at adding documentating while reviewing our releases changelog. However, a post in #api-docs will give them an earlier heads up.

All help docs are generated into references pages, automatically. But the docs team may decide to create dedicated guides for sandbox management.

mwbrooks

🙏🏻 Thanks for removing the experiment @vegeris

✏️ I've left a few change request suggestions. In the future, I'd encourage the PR to only remove the experiment and add other additions in separate PRs. It allows both the documentation team to spot changes easier and our GitHub Release Notes (based on PR titles) to communicate the changes to our developers.

mwbrooks · 2026-04-29T16:08:45Z

+	"it-incident-management": 4,
+	"customer-support":       5,
+	"sales":                  6,
+	"marketing":              7,


Thanks @vegeris. In the future, it would be better for this to be a separate PR so that it can stand out in the GitHub Release Notes and Changelog.

suggestion: Can you please update the Changelog section of this PR Description so that the documentation team knows to document it on docs.slack.dev.

mwbrooks · 2026-04-29T16:10:37Z

+	"it-incident-management": 4,
+	"customer-support":       5,
+	"sales":                  6,
+	"marketing":              7,


suggestion: @vegeris Can you please add these to the Long Description so that developers can discover the partner template Ids that are available to use?

mwbrooks · 2026-04-29T16:12:05Z

Huh (Charm) is now the default and only prompt library. So, if you're using a prompt then you're now using Charm's Huh :)

mwbrooks · 2026-04-29T16:13:30Z

 	ErrDotEnvFileRead                                = "dotenv_file_read_error"
 	ErrDotEnvFileWrite                               = "dotenv_file_write_error"
 	ErrDotEnvVarMarshal                              = "dotenv_var_marshal_error"
+	ErrDomainLong                                    = "domain_long"


suggestion: Can this please be prefixed with ErrSandboxDomainLong = "sandbox_domain_long" so that we know it's part of the Sandbox error codes. You'll need to reorganize it alphabetically.

💯 Updated this error code and alphabetized the sandbox error codes added previously!

🚧 question(non-blocking): Are these error codes from the upstream APIs? I'm hesitant to prefix the error variables with "sandbox" but not the error code.

zimeg

@vegeris So excited this made it to the finish line - superb 🏁

I'm leaving a few comments on changes here because inline comments are not working right now?

The error codes for sandbox_already_deleted and password_too_short don't have messages included with the codes and I'm not sure if that's something for the backend or CLI?
The sandbox create password prompt appears as plain text when I expected it to be hidden?

Otherwise nothing blocking! The above might be intentional or for another PR too. Whenever is best please feel free to merge for this upcoming release! 🔮 ✨

Edit: Oopies looks like comments are truncated too! I will continue this but LGTM 🚢

zimeg · 2026-05-06T15:21:17Z

 	ErrDotEnvFileRead                                = "dotenv_file_read_error"
 	ErrDotEnvFileWrite                               = "dotenv_file_write_error"
 	ErrDotEnvVarMarshal                              = "dotenv_var_marshal_error"
+	ErrDomainLong                                    = "domain_long"


🚧 question(non-blocking): Are these error codes from the upstream APIs? I'm hesitant to prefix the error variables with "sandbox" but not the error code.

zimeg · 2026-05-06T15:25:53Z

+	"it-incident-management": 4,
+	"customer-support":       5,
+	"sales":                  6,
+	"marketing":              7,


process for getting new commands documented

@vegeris The changelog included in the PR description might be alright to find this with next release! But let's keep watch of the published release! Reference should be generated automatic FWIW.

Perhaps now we can also update the experiments page to note the conclusion?

🔗 https://docs.slack.dev/tools/slack-cli/reference/experiments

zimeg · 2026-05-06T15:26:00Z

+	"it-incident-management": 4,
+	"customer-support":       5,
+	"sales":                  6,
+	"marketing":              7,


👾 ramble: I might also agree with separate PRs for future changes to make review more "obvious" for me with a single focused mind but I understand this now 🌚

mwbrooks

📝 Thanks for the edits @vegeris! 🙇🏻

I've left a few more comments. The largest one is renaming the error codes (go variables and error code strings) to be prefixed with sandboxes, unless they're meant to be used by other areas of the CLI codebase.

🪙 🪙 I think this has been mentioned, but in the future please try to keep PRs focused. This PR should be focused on removing the experiment flag, but it's doing quite a bit more. It makes reviewing the PR difficult and the CHANGELOG will fail to capture what true scope of the PR.

mwbrooks · 2026-05-07T05:09:54Z

+	"it-incident-management": 4,
+	"customer-support":       5,
+	"sales":                  6,
+	"marketing":              7,


I wasn't sure if we would want to highlight it in the Long Description as the grand majority of users would be regular non-partner developers

I feel we under utilitize the Long Description at the moment. We should feel comfortable documenting commands at length in the Long Description. After all, it's only shown when a developer wants to learn about that command, specifically. It's also generated into a webpage on docs.slack.dev.

All of that is to say, feel free to go full essay in a Long Description.

mwbrooks · 2026-05-07T05:11:38Z

+	"it-incident-management": 4,
+	"customer-support":       5,
+	"sales":                  6,
+	"marketing":              7,


My current assumption was that we would have a brief announcement in the Changelog through this PR and that once these changes are included in a release, that I would post in #api-docs to get the commands documented on docs.slack.dev?

Yep, this is a good approach. Typically, the docs team is good at adding documentating while reviewing our releases changelog. However, a post in #api-docs will give them an earlier heads up.

All help docs are generated into references pages, automatically. But the docs team may decide to create dedicated guides for sandbox management.

mwbrooks · 2026-05-07T05:17:44Z

 	ErrAppNotHosted                                  = "app_not_hosted"
 	ErrAppRemove                                     = "app_remove_error"
 	ErrAppRenameApp                                  = "app_rename_app"
+	ErrAtActiveSandboxLimit                          = "at_active_sandbox_limit"


suggestion: I'd like to see all of these new error codes prefixed with sandbox, similar to how our other error codes are prefixed with app, auth, etc. While our error codes aren't perfect, we're trying to keep the new ones more organized.

They should also be organized alphabetically after renamed.

For example:

Suggested change

ErrAtActiveSandboxLimit = "at_active_sandbox_limit"

ErrSandboxAtActiveLimit = "sandbox_at_active_limit"

rm experiment flag

b9cf57f

vegeris added 2 commits April 29, 2026 10:20

incl partner template names, new err code msg

ce63d49

Merge branch 'main' into evegeris-rm-sandbox-experiment

2342ef9

vegeris commented Apr 29, 2026

View reviewed changes

vegeris marked this pull request as ready for review April 29, 2026 14:30

vegeris requested a review from a team as a code owner April 29, 2026 14:30

vegeris commented Apr 29, 2026

View reviewed changes

vegeris added the semver:minor Use on pull requests to describe the release version increment label Apr 29, 2026

srtaalej added the experiment Experimental feature accessed behind the --experiment flag or toggle label Apr 29, 2026

srtaalej assigned vegeris Apr 29, 2026

mwbrooks added this to the Next Release milestone Apr 29, 2026

mwbrooks changed the title ~~feat: Remove the experiment flag for the sandbox commands~~ feat: remove the experiment flag for the sandbox commands Apr 29, 2026

mwbrooks requested changes Apr 29, 2026

View reviewed changes

mwbrooks changed the title ~~feat: remove the experiment flag for the sandbox commands~~ feat: remove the experiment flag for the sandbox commands and add new partner template IDs Apr 29, 2026

mwbrooks added enhancement M-T: A feature request for new functionality changelog Use on updates to be included in the release notes labels Apr 29, 2026

vegeris added 2 commits April 30, 2026 09:25

alphabetize sandbox errors

9c99351

update info log

508df39

vegeris requested a review from mwbrooks April 30, 2026 19:14

Merge branch 'main' into evegeris-rm-sandbox-experiment

68c447d

vegeris requested a review from srtaalej May 1, 2026 14:06

Merge branch 'main' into evegeris-rm-sandbox-experiment

5ff1a11

zimeg approved these changes May 6, 2026

View reviewed changes

mwbrooks reviewed May 7, 2026

View reviewed changes

	ErrAtActiveSandboxLimit = "at_active_sandbox_limit"
	ErrSandboxAtActiveLimit = "sandbox_at_active_limit"

Conversation

vegeris commented Apr 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changelog

Summary

Testing

Requirements

Uh oh!

codecov Bot commented Apr 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mwbrooks Apr 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vegeris Apr 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mwbrooks left a comment

Choose a reason for hiding this comment

Uh oh!

mwbrooks Apr 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

zimeg left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mwbrooks left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

vegeris commented Apr 28, 2026 •

edited

Loading

codecov Bot commented Apr 28, 2026 •

edited

Loading

mwbrooks Apr 29, 2026 •

edited

Loading

vegeris Apr 30, 2026 •

edited

Loading

mwbrooks Apr 29, 2026 •

edited

Loading

zimeg left a comment •

edited

Loading